Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ellipsis reactivity #171

Merged
merged 28 commits into from
Nov 30, 2018
Merged

Fix ellipsis reactivity #171

merged 28 commits into from
Nov 30, 2018

Conversation

jgribonvald
Copy link
Contributor

Some fix on reactivity around ellipsis component (clamping)

@jgribonvald jgribonvald requested review from ChristianMurphy and bjagg and removed request for bjagg November 21, 2018 20:09
@ChristianMurphy ChristianMurphy added enhancement New feature or request work in progress changes are still being developed, don't merge yet semver minor a new feature, that will require releasing a minor version and removed work in progress changes are still being developed, don't merge yet labels Nov 21, 2018
@jgribonvald jgribonvald force-pushed the fix_ellipsis_reactivity branch from 30d03fd to 9725b1c Compare November 21, 2018 22:11
@jgribonvald jgribonvald force-pushed the fix_ellipsis_reactivity branch from 9725b1c to 9d1dbba Compare November 23, 2018 17:52
@jgribonvald
Copy link
Contributor Author

New update, sorry I didn't find a way to solve problems !
I will try to put a demo page next week ;)

@jgribonvald
fix(esco-centent-menu): reactivity pbs when toggle visibility
de50a1f
@jgribonvald
feat(esco-content-menu): enhance clamping to auto fit on content
2b910b0
@jgribonvald
feat(esco-content-menu): improve clamping on resize event
37a135f
@jgribonvald
fix(esco-content-menu): improve reactivity on favorites content
e07ff7b
@jgribonvald
fix(esco-content-menu): apply bg is dark on fav only on small card
d9d7349
@jgribonvald
fix(esco-content-menu): check Number, manage correctly size 0 on hidden
eba35c8
@jgribonvald
fix(esco-content-menu): apply missing destroy of event listened
9d4c710
@jgribonvald
fix(esco-content-menu): eslint warning on authorized console
0ee03a3
@jgribonvald
fix(esco-content-menu): better/not perfect css detection of smartphone
bfeb9c4
@jgribonvald
fix(esco-centent-menu): reactivity on inited screen size when hidding
fefac09
@jgribonvald
fix(esco-content-menu): missing call needed on not isHidden
59d6432
@jgribonvald
chore(esco-content-menu): apply oidc version change 1.18.2
018289c
@jgribonvald
feat(esco-content-menu): add autofocus on filter input
1587abb
@jgribonvald
fix(esco-content-menu): avoid potential errors on standalone
d5f0dcd
@jgribonvald jgribonvald force-pushed the fix_ellipsis_reactivity branch from 9c7e3c4 to 32f0616 Compare November 27, 2018 16:15
@jgribonvald jgribonvald force-pushed the fix_ellipsis_reactivity branch from c53d15a to 949f8da Compare November 30, 2018 08:52
@ChristianMurphy ChristianMurphy merged commit b32d7b0 into uPortal-Project:master Nov 30, 2018
@jgribonvald jgribonvald deleted the fix_ellipsis_reactivity branch November 30, 2018 16:49
@ChristianMurphy ChristianMurphy mentioned this pull request Dec 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@bjagg bjagg Awaiting requested review from bjagg

Assignees
No one assigned
Labels
enhancement New feature or request semver minor a new feature, that will require releasing a minor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgribonvald @ChristianMurphy