Fail on unknown manifest keys + Add [tool] section for 3rd-party tools
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tingerrr
force-pushed
the
tool-section
branch
2 times, most recently
from
732c4ee to
9415f1d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
laurmaedje
reviewed
Jan 8, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR denies unknown fields in both the package manifest and package section of the manifest, ensuring typos are caught by CI. To still allow external configuration, 3rd-party tools can use an entry in the
[tool]section of the document.This change is backwards compatible with all existing packages, one notable packages came up during testing,
drafting:0.1.2, which already used[tool]without my prior knowledge.