Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acrostiche:0.3.1 #326

Merged
merged 13 commits into from
Jan 6, 2024
Merged

Acrostiche:0.3.1 #326

merged 13 commits into from
Jan 6, 2024

Conversation

Grisely
Copy link
Contributor

@Grisely Grisely commented Jan 6, 2024

I am submitting

  • a new package
  • an update for a package

Description: Merged a contribution from @caemor to fix an error when an array of one description was provided without a trailing comma.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE

@Grisely
Copy link
Contributor Author

Grisely commented Jan 6, 2024

This PR seems to want to merge all commits I have for this package again. I am not sure this is the expected behaviour (I am still trying to figure out Github's forks). Let me know if I need to change something.

@laurmaedje
Copy link
Member

Because I squash-merged your first PR, the commits from your fork aren't present in this repository. When starting on a new PR, ideally you would first sync up your fork with the upstream (this) repository. The easiest way to do this is to keep pull requests on separate branches of your repository instead of main and update main before starting a new feature branch. The diff looks okay though, so it shouldn't matter for this PR.

@laurmaedje laurmaedje added the update A package update. label Jan 6, 2024
@laurmaedje laurmaedje merged commit 3cde453 into typst:main Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update A package update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants