Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curryst:0.1.1 #289

Merged
merged 22 commits into from
Jan 31, 2024
Merged

curryst:0.1.1 #289

merged 22 commits into from
Jan 31, 2024

Conversation

pauladam94
Copy link
Contributor

  • Adding Examples
  • Fixing typesetting issue for rule with only one name

@MDLC01
Copy link
Contributor

MDLC01 commented Dec 8, 2023

Wasn't the previous version already 0.1.0?

@emilyyyylime
Copy link

@MDLC01 The previous version wasn't yet accepted

@MDLC01
Copy link
Contributor

MDLC01 commented Dec 8, 2023

Isn't this the previous version : https://github.com/typst/packages/tree/main/packages/preview/curryst/0.1.0
Which was added in the last commit c0cf9fc

@laurmaedje
Copy link
Member

The previous version was indeed accepted, so these changes would have to be submitted as a new version.

@laurmaedje laurmaedje added the update A package update. label Dec 10, 2023
@pauladam94
Copy link
Contributor Author

My bad i should have change the version. I will do it.

@laurmaedje laurmaedje marked this pull request as draft December 28, 2023 09:56
@laurmaedje
Copy link
Member

Hey @pauladam94, is this PR still on your radar?

@pauladam94
Copy link
Contributor Author

Hey @pauladam94, is this PR still on your radar?

Yes. I am just very busy and I have not take the time now to complete this PR.
I will have time in the next two weeks approximately.

@pauladam94 pauladam94 changed the title Curryst 0.1.0 Curryst 0.1.1 Jan 22, 2024
@pauladam94
Copy link
Contributor Author

@laurmaedje I think everything is in order now.

@laurmaedje laurmaedje changed the title Curryst 0.1.1 curryst:0.1.1 Jan 23, 2024
@laurmaedje laurmaedje marked this pull request as ready for review January 23, 2024 13:08
laurmaedje
laurmaedje reviewed Jan 23, 2024
View reviewed changes
packages/preview/curryst/0.1.1/README.md Outdated
A Typst package for typesetting proof trees. You can import this package with :

```typst
#import "@preview/curryst:0.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#import "@preview/curryst:0.1.0"
#import "@preview/curryst:0.1.1"

pauladam94
pauladam94 commented Jan 23, 2024
View reviewed changes
Copy link
Contributor Author

@pauladam94 pauladam94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version fix in the example on how to import the package

@pauladam94
Copy link
Contributor Author

Do I have to do something else about this PR ?

@laurmaedje
Copy link
Member

It looks like you didn't push the change.

@pauladam94
Copy link
Contributor Author

@laurmaedje I think I have now ? I am not sure what has to be done on my part.

@laurmaedje
Copy link
Member

The readme still says "0.1.0" in GitHub rather than "0.1.1":

@pauladam94
Copy link
Contributor Author

Ok I thought that your comment on the code had an effect. But I had to change it my self ! It's done now I think.

@laurmaedje laurmaedje merged commit d9017d5 into typst:main Jan 31, 2024
1 check passed
@laurmaedje
Copy link
Member

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurmaedje laurmaedje laurmaedje left review comments

Assignees
No one assigned
Labels
update A package update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pauladam94 @MDLC01 @emilyyyylime @laurmaedje