Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optionalDependencies instead of postinstall script #6

Merged
merged 31 commits into from
Dec 18, 2023
Merged

Use optionalDependencies instead of postinstall script #6

merged 31 commits into from
Dec 18, 2023

Conversation

jcbhmr
Copy link
Member

@jcbhmr jcbhmr commented Dec 18, 2023

This has the benefit of:

  • Being more easily downloadable from an offline cache
  • Conforming with ecosystem conventions (ex: optionalDependencies is what https://napi.rs uses)
  • Not requiring postinstall permissions (if user disables npm scripts optionalDependencies still works)

First trial release is https://www.npmjs.com/package/typst/v/0.10.0-6

works like a charm on my Windows 10 x64 PC and in WSL Linux x64 🎉🎉🎉

@jcbhmr jcbhmr merged commit c80f948 into typst-community:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant