test(server): add tests for Maven metadata building #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzema12
commented
Feb 24, 2025
| val availableMajorVersions = | ||
| fetchAvailableVersions(owner = owner, name = name, githubToken = githubToken) | ||
| fetchAvailableVersions(owner, name, githubToken) |
There was a problem hiding this comment.
I was hoping we could keep the named arguments for this call when adding a way to mock this function, but without a bit bigger refactoring (wrapping the function in a class or making the function accept ActionCoords) it seems to be not possible.
Vampire
previously approved these changes
Feb 24, 2025
...src/test/kotlin/io/github/typesafegithub/workflows/mavenbinding/MavenMetadataBuildingTest.kt
Outdated
Show resolved
Hide resolved
...src/test/kotlin/io/github/typesafegithub/workflows/mavenbinding/MavenMetadataBuildingTest.kt
Outdated
Show resolved
Hide resolved
...src/test/kotlin/io/github/typesafegithub/workflows/mavenbinding/MavenMetadataBuildingTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Björn Kautler <Bjoern@Kautler.net>
Vampire
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1611.
We're going to make some changes in the function, so let's add some safety net to prevent regressions + a way to see how the modified function behaves.