-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(abg)!: allow to wire typed outputs to matching typed inputs #1624
base: vampire/binding-version-v2
Are you sure you want to change the base?
feat(abg)!: allow to wire typed outputs to matching typed inputs #1624
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ff26830
to
46ca5ad
Compare
So far it indeed seems to work just great. |
Main remaining problem is probably the naming at https://github.com/typesafegithub/github-workflows-kt/pull/1624/files#diff-76c4a08acf57b6c491c34cc60e6ad7bbc219fbd45dc0dda74550941ecac51200 :-/ |
46ca5ad
to
14d4f80
Compare
Of course the typing catalog should be polished to have proper output types which it currently does not have. |
14d4f80
to
f4b6351
Compare
3a53468
to
f0429b9
Compare
Forgot the job outputs, now they are also typed :-) |
adbea5b
to
59626c0
Compare
And now |
90360a0
to
09d160e
Compare
d7c1b5d
to
f3b7790
Compare
2167254
to
71c6dd8
Compare
d42909a
to
9d293a1
Compare
71c6dd8
to
af313d2
Compare
9d293a1
to
30dd897
Compare
af313d2
to
ed8762b
Compare
30dd897
to
9d65dc9
Compare
ed8762b
to
06a5920
Compare
9d65dc9
to
cd64a8e
Compare
06a5920
to
1cc527e
Compare
cd64a8e
to
62d0334
Compare
1cc527e
to
eab1aa8
Compare
62d0334
to
1692740
Compare
e149347
to
3f62e51
Compare
474be17
to
787378a
Compare
787378a
to
5756304
Compare
29455da
to
5ea294c
Compare
5756304
to
d5329c4
Compare
5ea294c
to
56f3508
Compare
d5329c4
to
761f1e9
Compare
56f3508
to
aa3ec98
Compare
761f1e9
to
6da11d6
Compare
Fixes #73
If types of input and output match, you can do
lookupOnlyExpression = cache.outputs.cacheHit
If types do not match for whatever reason, you can still do
lookupOnlyExpression = cache.outputs.cacheHit_Untyped
or
or (but deprecated)
lookupOnly_Untyped = cache.outputs.cacheHit.expressionString
If no type is declared for the output, you can still stuff the
_Untyped
one into any expression input likelookupOnlyExpression = cache.outputs.cacheHit_Untyped
Ad-hoc outputs behave like untyped outputs in that you can stuff it into everywhere