fix: fix version comparison between versions with different part count (

#1838)
typesafegithub · Feb 24, 2025 · f7c8d20 · f7c8d20
1 parent bb270d4
commit f7c8d20
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/...ernal/src/main/kotlin/io/github/typesafegithub/workflows/shared/internal/model/Version.kt b/...ernal/src/main/kotlin/io/github/typesafegithub/workflows/shared/internal/model/Version.kt
@@ -25,6 +25,9 @@ data class Version(
                 return -1
             } else if (otherIntPart == null) {
                 return 1
+            } else {
+                val comparison = intPart.compareTo(otherIntPart)
+                if (comparison != 0) return comparison
             }
         }
         if (versionParts.size < other.versionParts.size) return -1

diff --git a/...l/src/test/kotlin/io/github/typesafegithub/workflows/shared/internal/model/VersionTest.kt b/...l/src/test/kotlin/io/github/typesafegithub/workflows/shared/internal/model/VersionTest.kt
@@ -52,6 +52,9 @@ class VersionTest :
                     Triple("alpha", "beta", false),
                     Triple("1.2.3", "1.2.3.4", false),
                     Triple("3.2.1", "v3", true),
+                    Triple("v1.2.1", "v2", false),
+                    Triple("v1.2", "v2", false),
+                    Triple("v1.2.1", "v1.3", false),
                 ).forEach { (left, right, leftIsGreater) ->
                     test("compareTo works correctly for $left vs. $right") {
                         if (leftIsGreater) {