Disable autofocus of SearchBar for keyboard-navigation friendly #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use autofocus sparingly with accessibility in mind. - Change default value in SearchBar component, autofocus true => false. - Still explicitly set autofocus prop in universal-header.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR tries to address an accessibility issue:
Issue
I often visit twreporter site from shared links (mostly to Article pages), and notice that I can't use Page Up/Down or Home/End keys to scroll.
This only happens in first visited page, subsequent navigation works fine.
The cause is that "search" input in the header automatically gets focus and intercepts all keyboard input.
Even more frustratingly, sometimes scrolling works at first, but once the page fully loads, it suddenly jumped back to top, and such keys stop responding. (this PR doesn't resolve the jumping back behavior)
Clarification: I'm using Firefox. Chrome/Edge can response PageDown in this scenario, but still not Home/End.
Notice
Most component consumers already set autofocus to
false, but pages usingUniversalHeader(e.g., Article) havetrue.It can be safely turned off because the focus behavior is already handled by
handleClickSearch.Dependency
None.