feat: add explicit width, height to image #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch sets an explicit width and height on image elements to reduce layout shifts and improve CLS (Cumulative Layout Shift).
This patch sets an explicit width and height on image elements utilized in index page to reduce layout shifts and improve CLS (Cumulative Layout Shift).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Set an explicit width, height and aspect-ratio on image elements
According to page speed insights, there is a diagnostic that suggest to set explicit width, height on image elements.
This is what this PR does. We can set the width and height of mobile image as the default value for image elements.
And since we adjust the width and height to fit its containers by css (e.g. width="100%"), it still keeps the aspect ratio of images, such as:
The computed width and height of an image is subject to the customized css style (e.g. the value computed by width="100%").