Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator precedence in descriptor length serialization #78

Conversation

AudaciousAxiom
Copy link
Contributor

Thank you for the work on this crate!

I believe the serialization of descriptor lengths requires an extra pair of parentheses, as Clippy hints to with its precedence lint. The & operator has higher precedence than >>.

@AudaciousAxiom
Copy link
Contributor Author

That was fast, thanks a lot! As Clippy is also complaining about the explicit lifetime which could be elided, I've just pushed another commit that elides it.

@twitchyliquid64
Copy link
Owner

Thanks

@twitchyliquid64
Copy link
Owner

twitchyliquid64 commented Mar 15, 2025

I love that word ‘elide’, it’s such a cool word, even though I only roughly know what it means

@twitchyliquid64 twitchyliquid64 merged commit 21bac9a into twitchyliquid64:master Mar 15, 2025
8 checks passed
@AudaciousAxiom
Copy link
Contributor Author

Thanks for merging this that quickly!

@twitchyliquid64
Copy link
Owner

No yoouuuu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants