You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my recent PRs, there has been some discussion around what constitutes part of the towncrier public API.
@adiroiban has asked around any changes to method names that aren't underscored, or adding new methods without underscores, with the consideration that since they can be imported, they could be considered "public".
My opinion is that only document methods receive public API treatment and it should be fine to change the signatures of any methods, and that it's not necessary to mark internal-only methods with an underscore prefix. But I'm fine doing that if that's the policy of the project!
Either way, to avoid confusion, perhaps this can be explicitly documented.
The text was updated successfully, but these errors were encountered:
In my recent PRs, there has been some discussion around what constitutes part of the towncrier public API.
@adiroiban has asked around any changes to method names that aren't underscored, or adding new methods without underscores, with the consideration that since they can be imported, they could be considered "public".
My opinion is that only document methods receive public API treatment and it should be fine to change the signatures of any methods, and that it's not necessary to mark internal-only methods with an underscore prefix. But I'm fine doing that if that's the policy of the project!
Either way, to avoid confusion, perhaps this can be explicitly documented.
The text was updated successfully, but these errors were encountered: