-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): update data viz docs with plugin and license info #4228
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
View your CI Pipeline Execution ↗ for commit 38c8740.
☁️ Nx Cloud last updated this comment at |
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Paste
|
Project |
Paste
|
Branch Review |
feat-website-data-viz-figma-and-license
|
Run status |
|
Run duration | 01m 56s |
Commit |
|
Committer | Sarah |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
67
|
View all changes introduced in this branch ↗︎ |
Paste
|
Project |
Paste
|
Branch Review |
feat-website-data-viz-figma-and-license
|
Run status |
|
Run duration | 06m 10s |
Commit |
|
Committer | Sarah |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
125
|
View all changes introduced in this branch ↗︎ |
@@ -67,6 +66,8 @@ The easiest way to use the data visualization tokens in your charts is to use `u | |||
|
|||
Be sure to include the [Highcharts Accessibility module](/foundations/data-visualization#adding-highcharts-accessibility-module) to ensure that your charts are accessible to all users. | |||
|
|||
The design systems team maintains a Highcharts license for Twilio Console, SendGrid, Flex, Segment, and Admin. If you are a Twilio customer building with Highcharts, you'll need [your own license](https://shop.highcharts.com/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't think we should mention "Admin" (which should be one admin). It's an internal tool and we may not want to expose that. We could add something like, for internal products please reach out to the team or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call—updated!
No description provided.