Show which calendar the event belongs to at event preview #8386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -202,6 +208,29 @@ export class EventPreviewView implements Component<EventPreviewViewAttrs> { | |||
| if (sanitizedDescription == null || sanitizedDescription.length === 0) return null | |||
| return this.renderRow(Icons.AlignLeft, [m.trust(sanitizedDescription)], true) | |||
| } | |||
|
|
|||
| private renderCalendar(calendarName: string | undefined, calendarColor: string | undefined, calendarRenderType: TranslationKey | undefined) { | |||
There was a problem hiding this comment.
Any specific reason for using string | undefined instead of ?: string ?
There was a problem hiding this comment.
I'll raise error instead of returning null/undefined. This values should never be undefined.
murilopereirame
force-pushed
the
dev-calendar
branch
from
30a33d9 to
d07a5cf
Compare
andrehgdias
force-pushed
the
dev-calendar
branch
from
d07a5cf to
167c8dd
Compare
murilopereirame
force-pushed
the
dev-calendar
branch
from
167c8dd to
dbbf01a
Compare
murilopereirame
force-pushed
the
7209-calendar-events-show-which-calendar-they-belong-to
branch
from
11df55f to
ae24e11
Compare
Add calendar info, color, name, and type, at event popup and event details (search and agenda view) Changes icon alignment to always align to the top, except when the data displayed fits in a single line, in this case it's centered.
andrehgdias
force-pushed
the
7209-calendar-events-show-which-calendar-they-belong-to
branch
from
ae24e11 to
cacd38c
Compare
andrehgdias
deleted the
7209-calendar-events-show-which-calendar-they-belong-to
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add calendar info, color, name, and type, at event popup and event details (search and agenda view)
Changes icon alignment to always align to the top, except when the data displayed fits in a single line, in this case it's centered.
Closes #7209