Skip to content

Commit

Permalink
Fix ViewColumn still tabbable when off-screen in single-column layout
Browse files Browse the repository at this point in the history
While setting ViewColumn's `aria-hidden` to `true` when not visible
works for mobile screen readers. The ViewColumn can still be tabbed
into. To make sure the ViewColumn is ignored, we use `inert` instead.

Close #7054
  • Loading branch information
hrb-hub authored and charlag committed Dec 20, 2024
1 parent 73fc544 commit f827c9b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/common/gui/base/ViewColumn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export class ViewColumn implements Component<Attrs> {
".view-column.fill-absolute",
{
...landmark,
"aria-hidden": this.isVisible || this.isInForeground ? "false" : "true",
inert: !this.isVisible && !this.isInForeground,
oncreate: (vnode) => {
this.domColumn = vnode.dom as HTMLElement
this.domColumn.style.transform =
Expand Down

0 comments on commit f827c9b

Please sign in to comment.