fix Tusky sometimes displaying empty tabs #5007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes a tab is just empty after switching to it, but content appears as soon as you interact with it.
I found that setting a
offscreenPageLimiton theViewPager2makes that issue go away.This also has the side effect that the content of more tabs is preloaded, which makes tab switching feel different, one does not see so many loading spinners, content is just there instantly. I'm not sure if that is desireable but I would like to try it out for a while. If it happens to be a problem we can still move tab initialization to when it is actually visible.