Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): readonly prop should only be Boolean #6397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jizai1125
Copy link
Contributor

@jizai1125 jizai1125 commented Sep 27, 2024

readonly: {
   type: [String, Boolean]
}
<!-- parsed as an empty string -> readonly="" -->
<n-input readonly  />

The readonly prop used to accept both String and Boolean, but was parsed as readonly="", which made the clear icon show up.

image

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
naive-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 7:14am

@jizai1125 jizai1125 changed the title fix(input): readonly prop should only be Boolean due to Vue casting rule fix(input): readonly prop should only be Boolean Sep 27, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.28%. Comparing base (c96427d) to head (55e609e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6397   +/-   ##
=======================================
  Coverage   59.28%   59.28%           
=======================================
  Files        1149     1149           
  Lines       25434    25434           
  Branches     6412     6412           
=======================================
  Hits        15078    15078           
  Misses       8682     8682           
  Partials     1674     1674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants