Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AzureService is using a deprecated SDK (github.com/Azure/azure-storage-blob-go/azblob) #1135

Closed
vikas-rajvanshy opened this issue May 20, 2024 · 1 comment · Fixed by #1205

Comments

@vikas-rajvanshy
Copy link

Is your feature request related to a problem? Please describe.
github.com/Azure/azure-storage-blob-go/azblob is deprecated, will officially EOL later this year. The recommended replacement is github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/blockblob

Describe the solution you'd like
Port AzService to use the supported SDK

Describe alternatives you've considered
Tried replacing it myself, the changes across SDK's are substantial - needs someone with more context to make the change. Ex. seems like there is now a client per blob rather than singleton across lifetime.

Can you provide help with implementing this feature?
Don't have much context here, but willing to help

Additional context

@Acconut
Copy link
Member

Acconut commented May 21, 2024

Thank you for bringing this to our attention. I will try to have a look at this soon. A migration guide is at https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/storage/azblob/migrationguide.md, which seems rather simple, but your experience points in the other direction. Let's hope that the necessary changes on our side are not significant.

@Acconut Acconut linked a pull request Nov 26, 2024 that will close this issue
Acconut added a commit that referenced this issue Nov 26, 2024
* #1135 migration to current azure sdk

* fix findings

* make sure snapshots are deleted too

* Minor touches

* More touches

* Undo change in go.mod

---------

Co-authored-by: xelat09 <xelat09@localhost>
Co-authored-by: Marius Kleidl <marius@transloadit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants