Apply suggestions from code review

tus · Nov 26, 2024 · b01f913 · b01f913
1 parent f9847ef
commit b01f913
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cmd/tusd/cli/composer.go b/cmd/tusd/cli/composer.go
@@ -76,8 +76,8 @@ func CreateComposer() {
 				"Please remove underscore from the value", Flags.GCSObjectPrefix)
 		}
 
-		// Legacy: account file used to be provided by GCS_SERVICE_ACCOUNT_FILE environment variable.
-		// Now it is more common to default into ADC discovery mechanism.
+		// Application Default Credentials discovery mechanism is attempted to fetch credentials,
+		// but an account file can be provided through the GCS_SERVICE_ACCOUNT_FILE environment variable.
 		gcsSAF := os.Getenv("GCS_SERVICE_ACCOUNT_FILE")
 
 		service, err := gcsstore.NewGCSService(gcsSAF)

diff --git a/docs/_storage-backends/google-cloud-storage.md b/docs/_storage-backends/google-cloud-storage.md
@@ -18,7 +18,8 @@ $ tusd -gcs-bucket=my-test-bucket.com
 ...
 ```
 
-By default, Application Default Credentials [discovery mechanism](https://cloud.google.com/docs/authentication/external/set-up-adc) will be attempted.
+By default, [Application Default Credentials discovery mechanism](https://cloud.google.com/docs/authentication/external/set-up-adc) will be attempted.
+
 If `GCS_SERVICE_ACCOUNT_FILE` environment variable is provided, that account will be used instead:
 
 ```bash
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,7 +18,8 @@ $ tusd -gcs-bucket=my-test-bucket.com @@
     ...
     ```
-    By default, Application Default Credentials [discovery mechanism](https://cloud.google.com/docs/authentication/external/set-up-adc) will be attempted.
+    By default, [Application Default Credentials discovery mechanism](https://cloud.google.com/docs/authentication/external/set-up-adc) will be attempted.
     If `GCS_SERVICE_ACCOUNT_FILE` environment variable is provided, that account will be used instead:
     ```bash
@@ Expand Down @@