Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table scaleway_account_project #53

Merged
merged 15 commits into from
Jan 18, 2024
Merged

Add table scaleway_account_project #53

merged 15 commits into from
Jan 18, 2024

Conversation

jplanckeel
Copy link
Contributor

@jplanckeel jplanckeel commented Oct 18, 2023 •
edited
Loading

Context

Add table scaleway project. Needed for ParentHydrate for other table.

Blocked by PR #30 because we need organization_id in api call for account.

#hacktoberfest

Example query results

Results 
select * from scaleway_account_project
+--------------------------------------+-----------+---------------------------+---------------------------+----------------+--------------------------------------+-------------------------->
| project_id                           | name      | created_at                | updated_at                | description    | organization                         | _ctx                     >
+--------------------------------------+-----------+---------------------------+---------------------------+----------------+--------------------------------------+-------------------------->
| 13cabd62-29ef-46a6-967f-54oidcb2fc5  | default   | 2019-05-28T15:00:42+02:00 | 2020-05-03T20:31:50+02:00 | <null>         | 13coid62-29ef-46a6-967f-54iiadcb2fc5 | {"connection_name":"scale>
| 5c94558d-bc23-415e-bf37-1ec0010aec31 | steampipe | 2023-10-18T17:20:51+02:00 | 2023-10-18T17:20:51+02:00 | Test Steampipe | 13cabd62-29ef-46a6-967f-5433adcb2fc5 | {"connection_name":"scale>
+--------------------------------------+-----------+---------------------------+---------------------------+----------------+--------------------------------------+-------------------------->

@jplanckeel jplanckeel changed the base branch from main to add-iam-key-user-tables October 18, 2023 15:28
@jplanckeel jplanckeel changed the title feat: add table project BLOCKED: feat: add table project Oct 18, 2023
@cbruno10
Copy link
Contributor

@jplanckeel I'm going to hold off on reviewing this PR for now until #52 is merged and you can rebase your feature branch off of main (so less files show up as diffs).

@jplanckeel jplanckeel changed the base branch from add-iam-key-user-tables to main October 23, 2023 14:43
@jplanckeel jplanckeel force-pushed the feat/add-table-project branch from d7adc05 to 7a65fe6 Compare October 24, 2023 07:27
@jplanckeel jplanckeel changed the title BLOCKED: feat: add table project feat: add table scaleway_project Oct 24, 2023
cbruno10
cbruno10 requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@cbruno10 cbruno10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jplanckeel Thanks for rebasing so quickly! I've left a few comments, can you please have a look?

scaleway/table_scaleway_account_project.go Outdated Show resolved Hide resolved
scaleway/table_scaleway_account_project.go Outdated Show resolved Hide resolved
scaleway/table_scaleway_account_project.go Show resolved Hide resolved
scaleway/table_scaleway_account_project.go Show resolved Hide resolved
go.mod Outdated
@@ -4,7 +4,7 @@ go 1.21

require (
github.com/aws/aws-sdk-go v1.44.122
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.12
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any breaking changes from beta.12 to beta.21 we need to watch out for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don"t have BC when upgrade this deps. I have check other tables.

docs/tables/scaleway_account_project.md Show resolved Hide resolved
scaleway/table_scaleway_account_project.go Show resolved Hide resolved
@madhushreeray30 madhushreeray30 added the hacktoberfest-accepted This pull request has been accepted for Hacktoberfest label Oct 31, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Jan 1, 2024
@misraved
Copy link
Contributor

misraved commented Jan 2, 2024

@jplanckeel apologies for the delay in the review process, overall the PR looks good, could you please resolve the merge conflicts so that we can go for release?

@github-actions github-actions bot removed the stale No recent activity has been detected on this issue/PR and it will be closed label Jan 2, 2024
jplanckeel and others added 14 commits January 3, 2024 08:40
@jplanckeel
feat(golang): add table scaleway_iam_api_key (turbot#25)
ed13df3 
Co-authored-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
fix: change id by user_id
c67b44c 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
fix: user_id in table user
b779a7b 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
fix: organization_id is optional
003c87b 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
feat: add table project
7289039 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
fix: add error when organization_id is missing
bf35430 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
fix: column created_at and typo in docs
a402b80 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
revert: change after rebase
1365985 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
revert: remove change after rebase
e42415b 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
fix: update api account and rename table
0044d51 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
docs: update docs scaleway_account_project
1677c5d 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
fix: add KeyColumns and rename columns
05c8847 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
docs: update query for table scaleway_account_project
a9b3ba8 
Signed-off-by: jplanckeel <jplanckeel@scaleway.com>
@jplanckeel
feat: ad func getAccountProject
94a7609 
Signed-off-by: Jeremy PLANCKEEL <jeremy.planckeel@outlook.com>
@jplanckeel jplanckeel force-pushed the feat/add-table-project branch from 5615b6c to 94a7609 Compare January 3, 2024 07:41
@jplanckeel
fix: run go mod tidy
e4cbfc8 
Signed-off-by: Jeremy PLANCKEEL <jeremy.planckeel@outlook.com>
@jplanckeel
Copy link
Contributor Author

Hello, i have rebase the branch and resolve the conflict ;)

@bigdatasourav bigdatasourav changed the title feat: add table scaleway_project Add table scaleway_project Jan 18, 2024
@bigdatasourav bigdatasourav changed the title Add table scaleway_project Add table scaleway_account_project Jan 18, 2024
@bigdatasourav bigdatasourav merged commit 25ca2e1 into turbot:main Jan 18, 2024
1 check passed
@jplanckeel jplanckeel deleted the feat/add-table-project branch January 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhushreeray30 madhushreeray30 madhushreeray30 left review comments

@cbruno10 cbruno10 cbruno10 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted This pull request has been accepted for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jplanckeel @cbruno10 @misraved @madhushreeray30 @bigdatasourav