Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report configuration file loading failure as warning to avoid shutting down FDW #609

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Dec 18, 2024

Just like turbot/steampipe#4233, this PR resolves issues when connection configurations are created dynamically concurrently to executing queries.

Without this PR, the following errors would occur and terminate the FDW process, breaking all concurrent requests targeting other connections:

# grep "Internal Error: Failed to load all config files" .steampipe/logs/database-2024-12-18.log
2024-12-18 09:26:31.371 UTC [INFO]  hub: ERROR ErrorAndWarnings err="Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_012345678901.spc: open /builds/myproject/.steampipe/config/aws_012345678901.spc: no such file or directory" warnings=[]
2024-12-18 09:26:31.371 UTC [WARN]  hub: LoadConnectionConfig failed {Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_012345678901.spc: open /builds/myproject/.steampipe/config/aws_012345678901.spc: no such file or directory []}
panic: Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_012345678901.spc: open /builds/myproject/.steampipe/config/aws_012345678901.spc: no such file or directory
2024-12-18 09:29:01.157 UTC [INFO]  hub: ERROR ErrorAndWarnings err="Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_123456789012.spc: open /builds/myproject/.steampipe/config/aws_123456789012.spc: no such file or directory" warnings=[]
2024-12-18 09:29:01.157 UTC [WARN]  hub: LoadConnectionConfig failed {Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_123456789012.spc: open /builds/myproject/.steampipe/config/aws_123456789012.spc: no such file or directory []}
2024-12-18 09:29:01.157 UTC [ERROR] hub: LoadConnectionConfig failed Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_123456789012.spc: open /builds/myproject/.steampipe/config/aws_123456789012.spc: no such file or directory
2024-12-18 09:29:01.158 UTC [4933] WARNING:  lenient_select_setof_jsonb failed to execute query: Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_123456789012.spc: open /builds/myproject/.steampipe/config/aws_123456789012.spc: no such file or directory
2024-12-18 09:29:49.665 UTC [INFO]  hub: ERROR ErrorAndWarnings err="Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_234567890123.spc: open /builds/myproject/.steampipe/config/aws_234567890123.spc: no such file or directory" warnings=[]
2024-12-18 09:29:49.665 UTC [WARN]  hub: LoadConnectionConfig failed {Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_234567890123.spc: open /builds/myproject/.steampipe/config/aws_234567890123.spc: no such file or directory []}
2024-12-18 09:29:49.665 UTC [ERROR] hub: LoadConnectionConfig failed Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_234567890123.spc: open /builds/myproject/.steampipe/config/aws_234567890123.spc: no such file or directory
2024-12-18 09:29:49.665 UTC [5808] ERROR:  Internal Error: Failed to load all config files: failed to read config file /builds/myproject/.steampipe/config/aws_234567890123.spc: open /builds/myproject/.steampipe/config/aws_234567890123.spc: no such file or directory

@pdecat pdecat force-pushed the fix/warn_config_read_failure branch from d61f83b to 3ad205c Compare December 18, 2024 10:04
@pdecat pdecat changed the title fix: report configuration files loading failure as warning to avoid shutting down FDW fix: report configuration file loading failure as warning to avoid shutting down FDW Dec 18, 2024
@pdecat pdecat force-pushed the fix/warn_config_read_failure branch from 3ad205c to ee46f83 Compare December 18, 2024 10:05
@cbruno10 cbruno10 requested a review from kaidaguerre December 18, 2024 13:36
@pdecat pdecat force-pushed the fix/warn_config_read_failure branch from a95add7 to ee46f83 Compare December 18, 2024 15:57
@kaidaguerre
Copy link
Contributor

Hi @pdecat Thanks for this. Please rebase from develop

@pdecat pdecat force-pushed the fix/warn_config_read_failure branch from ee46f83 to 916661d Compare December 20, 2024 11:20
@pdecat
Copy link
Contributor Author

pdecat commented Dec 20, 2024

Done!

@kaidaguerre kaidaguerre changed the base branch from develop to v1.7.x January 7, 2025 14:28
@kaidaguerre kaidaguerre changed the base branch from v1.7.x to develop January 7, 2025 14:28
@kaidaguerre kaidaguerre force-pushed the fix/warn_config_read_failure branch from 916661d to 07709c7 Compare January 7, 2025 14:29
@kaidaguerre kaidaguerre merged commit c64e5bf into turbot:develop Jan 7, 2025
2 checks passed
@pdecat pdecat deleted the fix/warn_config_read_failure branch January 7, 2025 15:03
pskrbasu pushed a commit that referenced this pull request Jan 7, 2025
kaidaguerre pushed a commit that referenced this pull request Jan 7, 2025
* Support installing mods from Gitlab repositories. Closes #619

* v1.6.7

* fix: report configuration file loading failure as warning to avoid shutting down FDW (#609)

* update changelog

---------

Co-authored-by: Patrick Decat <pdecat@gmail.com>
@pskrbasu pskrbasu mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants