Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: explain how the algorithm works #41

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Conversation

gasche
Copy link
Contributor

@gasche gasche commented Apr 14, 2021

Fixes #8

README.md Outdated Show resolved Hide resolved
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
README.md Outdated Show resolved Hide resolved
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
@waldyrious
Copy link
Contributor

waldyrious commented Apr 14, 2021

I think it would be useful to add a link to https://github.com/tummychow/git-scripts/blob/master/git-absorb.md#interlude-patch-theory at the end of this section. For example:

For additional details, see the documentation here.

@gasche
Copy link
Contributor Author

gasche commented Apr 14, 2021

I'm not sure; this document is way too long and possibly outdated (for example it refers to an old implementation). I prefer to keep the proposed change as-is, will change if there is more feedback in favor.

@waldyrious
Copy link
Contributor

Sure, I can see your point. 👍

@tummychow
Copy link
Owner

yeah okay this is an acceptable summary. i agree that the old documentation shouldn't be referenced here, that form of commutation just does not work

@tummychow tummychow merged commit d414ea6 into tummychow:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

high-level description of algorithm
3 participants