copy evt.Codes to avoid concurrency issues #725
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in
emitQRs
function changes the original event,events.QR
.However, we send it already to other handlers, but we change it here.
In my case, I tried to
JSON.Marshal(evt)
and sometimes gotreflect: slice index out of range concurrency
error.It looks like instead of changing
evt.Codes
we should copy it first and then change copied slice.It's minor issue, but it's better not to change the values we already send outside, IMO.
Not sure if coping it before
Marshal
would help btw, because it'll be anyway concurrent access 🤔