Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add --tag flag to filter services in tsuru service list #234

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

prbn021
Copy link
Contributor

@prbn021 prbn021 commented Sep 26, 2024

The tsuru-client can now use the tsuru API's tag filtering feature for services instances. The "tsuru service list" command now supports the -g or --tag flags like tsuru service list -g key=value. I based this improvement on the way tsuru-client does the tsuru app list command.

Copy link
Contributor

@crgisch crgisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1744046). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tsuru/client/services.go 77.77% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage        ?   72.90%           
=======================================
  Files           ?       54           
  Lines           ?     9807           
  Branches        ?        0           
=======================================
  Hits            ?     7150           
  Misses          ?     1750           
  Partials        ?      907           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crgisch crgisch merged commit 83be8cd into tsuru:main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants