Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe list πŸ‘¨β€πŸ’» #11

Merged
merged 12 commits into from
Feb 6, 2024
Merged

Recipe list πŸ‘¨β€πŸ’» #11

merged 12 commits into from
Feb 6, 2024

Conversation

tsheporamantso
Copy link
Owner

Recipe list πŸ‘¨β€πŸ’»

On this milestone πŸ—Ώ I implemented the following

  • Recipes list:
    • Should display a list of recipes created by the logged-in user as in the wireframe. βœ”οΈ
    • Should lead to recipe details. βœ”οΈ
    • Add recipes controller file βœ”οΈ
    • Add recipes resourceful routing βœ”οΈ
    • Add basic styling βœ”οΈ
    • Check and correct rubocop offences βœ”οΈ
    • Check and correct stylelint errors βœ”οΈ

@tsheporamantso tsheporamantso linked an issue Feb 6, 2024 that may be closed by this pull request
1 task
Copy link
Collaborator

@Fombi-Favour Fombi-Favour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tsheporamantso ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸŽ‰

approved-target-lady

Highlights

βœ… Descriptive PR summary
βœ… Clean code
βœ… Design is closer to wireframe

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@tsheporamantso tsheporamantso merged commit 5c5cd4b into dev Feb 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] Recipe List Team Member #1
2 participants