Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model and controllers πŸ‘¨β€πŸ’» #10

Merged
merged 25 commits into from
Feb 5, 2024

Conversation

tsheporamantso
Copy link
Owner

Model and controllers πŸ‘¨β€πŸ’» ⚑

On this milestone, We implemented the following 🧠 🧠

  • Add models as per Entity Relationship Diagram βœ”οΈ
  • Add Validations and Associations βœ”οΈ
  • Add schema.rb file βœ”οΈ
  • Initialized and install devise for authentication πŸ”’
  • Add styling for device new session and new registration βœ”οΈ
  • Check and correct rubocop offenses πŸ€–
  • Check and correct stylelint errors βœ”οΈ

Copy link
Collaborator

@Fombi-Favour Fombi-Favour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tsheporamantso πŸ‘‹ ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! πŸ₯³ πŸŽ‰

[Optional] suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@tsheporamantso tsheporamantso merged commit b547db6 into dev Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants