Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.json() returns a string of used parameters #40

Merged
merged 5 commits into from
Sep 23, 2024
Merged

.json() returns a string of used parameters #40

merged 5 commits into from
Sep 23, 2024

Conversation

ShiboSoftwareDev
Copy link
Contributor

image

@ShiboSoftwareDev
Copy link
Contributor Author

ShiboSoftwareDev commented Sep 21, 2024 •
edited
Loading

TODO:

  • maybe passive functions should return this:
    image
    instead of this:
    image
  • maybe some default values should be default inside of the component definition like this one:
    image

@ShiboSoftwareDev
Copy link
Contributor Author

image
I haven't updated this type definition, should I?

@ShiboSoftwareDev
Copy link
Contributor Author

I have updated the format and it's still failing

seveibar
seveibar reviewed Sep 22, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except how parameters are stringified

src/fn/bga.ts Outdated
@@ -134,5 +137,5 @@ export const bga = (params: BgaDefInput): AnySoupElement[] => {
}
}

return [...pads]
return { circuitJson: [...pads], parameters: JSON.stringify(params) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why stringify?

Suggested change
return { circuitJson: [...pads], parameters: JSON.stringify(params) }
return { circuitJson: [...pads], parameters: params }

@ShiboSoftwareDev
Copy link
Contributor Author

@seveibar
image

@ShiboSoftwareDev ShiboSoftwareDev merged commit 1390491 into tscircuit:main Sep 23, 2024
1 check failed
This was referenced Sep 23, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiboSoftwareDev @seveibar