Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented VSSOP-8-0.65mm #184

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Implemented VSSOP-8-0.65mm #184

wants to merge 12 commits into from
+131 −0

Conversation

MustafaMulla29
Copy link

/claim #167

@algora-pbc algora-pbc bot mentioned this pull request Feb 11, 2025
Open
seveibar
seveibar reviewed Feb 13, 2025
View reviewed changes
src/fn/vssop8.ts Outdated Show resolved Hide resolved
seveibar
seveibar reviewed Feb 13, 2025
View reviewed changes
src/fn/vssop8.ts Outdated Show resolved Hide resolved
seveibar
seveibar requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@MustafaMulla29
Copy link
Author

@seveibar I have resolved the confilicts and tried to implement it again. Please review it!

@techmannih
Copy link
Collaborator

@MustafaMulla29 looks different!
image

@MustafaMulla29
Copy link
Author

MustafaMulla29 commented Feb 13, 2025 •
edited
Loading

@MustafaMulla29 looks different! image

@techmannih ohh! Sorry, I was confused, I saw the implementation of the tssop8 on the footprinter and on kicad. Both were different so I implemented with the same method as of tssop8.
So now I have to do exactly how it on kicad viewer? With only two lines, top and bottom?

@MustafaMulla29
Copy link
Author

image

@techmannih is this how it should be?

@techmannih
Copy link
Collaborator

@MustafaMulla29 looks different! image

@MustafaMulla29 we need exactly similar to this

@MustafaMulla29
Copy link
Author

@MustafaMulla29 looks different! image

@MustafaMulla29 we need exactly similar to this

Ok I'll make the changes and commit.

@MustafaMulla29
Copy link
Author

@techmannih you may review it now.

@MustafaMulla29
Copy link
Author

@seveibar can you review this

techmannih
techmannih suggested changes Feb 15, 2025
View reviewed changes
Copy link
Collaborator

@techmannih techmannih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add function in footprinter

@techmannih
Copy link
Collaborator

@MustafaMulla29 need to remove some unwanted comments

@MustafaMulla29
Copy link
Author

@techmannih Thanks for your response, I'll do that.

@MustafaMulla29
Copy link
Author

@techmannih Done!

@techmannih
Copy link
Collaborator

@MustafaMulla29 please resolve conflicts, according to latest PR merged.

@MustafaMulla29
Copy link
Author

@techmannih Resolved conflicts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techmannih techmannih techmannih requested changes

@seveibar seveibar Awaiting requested review from seveibar

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MustafaMulla29 @techmannih @seveibar