Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

border changes #179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Himanshu-Singh-Chauhan
Copy link

@Himanshu-Singh-Chauhan Himanshu-Singh-Chauhan commented Feb 5, 2025

Important

Add margin adjustments to various UI components in CSS files for layout consistency.

  • CSS Changes:
    • Add margin: 10px to .monaco-workbench .part.auxiliarybar in auxiliaryBarPart.css.
    • Add margin-top: 10px to .monaco-workbench .part.editor in editorgroupview.css.
    • Add margin: 10px to .monaco-workbench .part.sidebar in sidebarpart.css.
    • Add margin-top: 10px to .monaco-workbench .part.statusbar in statusbarpart.css.

This description was created by Ellipsis for 5523db7. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5523db7 in 41 seconds

More details
  • Looked at 86 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 9 drafted comments based on config settings.
1. src/vs/workbench/browser/parts/auxiliarybar/media/auxiliaryBarPart.css:8
  • Draft comment:
    Margin added (10px) may affect layout; also consider removing commented-out height adjustment if not needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None
2. src/vs/workbench/browser/parts/editor/media/editorgroupview.css:7
  • Draft comment:
    Added margin-top on .part.editor and height calc on empty containers—ensure these changes are consistent with overall layout.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None
3. src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css:7
  • Draft comment:
    Margin adjustments (margin-top on .nosidebar & margin on .part.sidebar) might affect the overall sidebar layout; verify if the hidden state and visible state align as intended.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None
4. src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css:14
  • Draft comment:
    Margin-top added to the statusbar may alter its vertical positioning; please confirm the visual intent.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None
5. src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css:28
  • Draft comment:
    Extra blank line(s) added; consider removing redundant whitespace for consistency.
  • Reason this comment was not posted:
    Confidence changes required: 30%
    None
6. src/vs/workbench/browser/parts/auxiliarybar/media/auxiliaryBarPart.css:9
  • Draft comment:
    Margin (10px) added to .part.auxiliarybar; please verify that this extra spacing doesn’t break the intended layout. Also, if the height adjustment via 'calc(100% - 10px)' is no longer needed, consider removing the commented code.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None
7. src/vs/workbench/browser/parts/editor/media/editorgroupview.css:9
  • Draft comment:
    Margin-top (10px) added to .part.editor. Ensure that the height calculation in empty editor groups (using calc(100% - 10px)) still aligns with the new margin and overall layout. Also, remove commented-out border/height styles if they’re no longer needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None
8. src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css:9
  • Draft comment:
    New margin settings (margin-top and overall margin of 10px) added for the sidebar. Please confirm these margins match design guidelines and consider cleaning up the unused commented height calculation.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None
9. src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css:14
  • Draft comment:
    The status bar (fixed height of 22px) now has a margin-top of 10px. Confirm that this extra spacing does not disrupt the layout alignment or appearance in the overall workbench.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    None

Workflow ID: wflow_L6FtXTViLmhyCBEy


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant