forked from microsoft/vscode
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
border changes #179
Open
Himanshu-Singh-Chauhan
wants to merge
1
commit into
trypear:main
Choose a base branch
from
Himanshu-Singh-Chauhan:newheaderbar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
border changes #179
Himanshu-Singh-Chauhan
wants to merge
1
commit into
trypear:main
from
Himanshu-Singh-Chauhan:newheaderbar
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 5523db7 in 41 seconds
More details
- Looked at
86
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
9
drafted comments based on config settings.
1. src/vs/workbench/browser/parts/auxiliarybar/media/auxiliaryBarPart.css:8
- Draft comment:
Margin added (10px) may affect layout; also consider removing commented-out height adjustment if not needed. - Reason this comment was not posted:
Confidence changes required:50%
None
2. src/vs/workbench/browser/parts/editor/media/editorgroupview.css:7
- Draft comment:
Added margin-top on .part.editor and height calc on empty containers—ensure these changes are consistent with overall layout. - Reason this comment was not posted:
Confidence changes required:50%
None
3. src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css:7
- Draft comment:
Margin adjustments (margin-top on .nosidebar & margin on .part.sidebar) might affect the overall sidebar layout; verify if the hidden state and visible state align as intended. - Reason this comment was not posted:
Confidence changes required:50%
None
4. src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css:14
- Draft comment:
Margin-top added to the statusbar may alter its vertical positioning; please confirm the visual intent. - Reason this comment was not posted:
Confidence changes required:50%
None
5. src/vs/workbench/browser/parts/titlebar/media/titlebarpart.css:28
- Draft comment:
Extra blank line(s) added; consider removing redundant whitespace for consistency. - Reason this comment was not posted:
Confidence changes required:30%
None
6. src/vs/workbench/browser/parts/auxiliarybar/media/auxiliaryBarPart.css:9
- Draft comment:
Margin (10px) added to .part.auxiliarybar; please verify that this extra spacing doesn’t break the intended layout. Also, if the height adjustment via 'calc(100% - 10px)' is no longer needed, consider removing the commented code. - Reason this comment was not posted:
Confidence changes required:50%
None
7. src/vs/workbench/browser/parts/editor/media/editorgroupview.css:9
- Draft comment:
Margin-top (10px) added to .part.editor. Ensure that the height calculation in empty editor groups (using calc(100% - 10px)) still aligns with the new margin and overall layout. Also, remove commented-out border/height styles if they’re no longer needed. - Reason this comment was not posted:
Confidence changes required:50%
None
8. src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css:9
- Draft comment:
New margin settings (margin-top and overall margin of 10px) added for the sidebar. Please confirm these margins match design guidelines and consider cleaning up the unused commented height calculation. - Reason this comment was not posted:
Confidence changes required:50%
None
9. src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css:14
- Draft comment:
The status bar (fixed height of 22px) now has a margin-top of 10px. Confirm that this extra spacing does not disrupt the layout alignment or appearance in the overall workbench. - Reason this comment was not posted:
Confidence changes required:50%
None
Workflow ID: wflow_L6FtXTViLmhyCBEy
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add margin adjustments to various UI components in CSS files for layout consistency.
margin: 10px
to.monaco-workbench .part.auxiliarybar
inauxiliaryBarPart.css
.margin-top: 10px
to.monaco-workbench .part.editor
ineditorgroupview.css
.margin: 10px
to.monaco-workbench .part.sidebar
insidebarpart.css
.margin-top: 10px
to.monaco-workbench .part.statusbar
instatusbarpart.css
.This description was created by
for 5523db7. It will automatically update as commits are pushed.