Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command center fixes #165

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Command center fixes #165

merged 2 commits into from
Jan 22, 2025

Conversation

nang-dev
Copy link

@nang-dev nang-dev commented Jan 22, 2025


Important

Remove unused chat command center code and add a comment in code.sh for submodule recompilation guidance.

  • Code Removal:
    • Remove ToggleCopilotControl class and MenuRegistry.appendMenuItem call related to MenuId.CommandCenter in chatActions.ts.
  • Scripts:
    • Add comment in code.sh to indicate when recompilation of pearai-submodule is necessary.

This description was created by Ellipsis for 3034e49. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0fccd27 in 14 seconds

More details
  • Looked at 55 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. scripts/code.sh:5
  • Draft comment:
    Consider making the recompilation of the pearai submodule optional via a script argument or environment variable for better flexibility.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The comment in the script suggests that recompiling the pearai submodule can be skipped for faster execution. This is a useful note for developers who might not need to recompile every time.

Workflow ID: wflow_1DnWpiUHLcHX9VBC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3034e49 in 12 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_RprNZsRvG7fOzQcZ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@nang-dev nang-dev merged commit 3613851 into main Jan 22, 2025
1 of 5 checks passed
nang-dev added a commit that referenced this pull request Jan 27, 2025
* Added command center fix

* fixed
nang-dev added a commit that referenced this pull request Jan 27, 2025
* Added command center fix

* fixed
nang-dev added a commit that referenced this pull request Jan 27, 2025
* Added command center fix

* fixed
nang-dev added a commit that referenced this pull request Jan 27, 2025
* Added command center fix

* fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant