Update shellIntegration-bash.sh #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Check if the system is NixOS if yes unset this var for fixing the error "Segmentation fault (core dumped)" [ -f /etc/NIXOS ] && unset LD_LIBRARY_PATH
InSelfControll
requested review from
nang-dev,
Fryingpannn and
a team
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 189af75 in 2 minutes and 4 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_10l70cZ6cnMnytfn
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -10,6 +10,9 @@ fi | |||
|
|
|||
| VSCODE_SHELL_INTEGRATION=1 | |||
|
|
|||
| # Check if the system is NixOS if yes unset this var for fixing the error "Segmentation fault (core dumped)" | |||
| [ -f /etc/NIXOS ] && unset LD_LIBRARY_PATH | |||
There was a problem hiding this comment.
The check for NixOS should use /etc/os-release instead of /etc/NIXOS for reliability. Consider using:
Suggested change
| [ -f /etc/NIXOS ] && unset LD_LIBRARY_PATH | |
| [ -f /etc/os-release ] && grep -q 'ID=nixos' /etc/os-release && unset LD_LIBRARY_PATH |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the system is NixOS if yes unset this var for fixing the error "Segmentation fault (core dumped)"
[ -f /etc/NIXOS ] && unset LD_LIBRARY_PATH
Important
Add check for NixOS in
shellIntegration-bash.shto unsetLD_LIBRARY_PATHand prevent segmentation faults.shellIntegration-bash.sh, check for NixOS by verifying the existence of/etc/NIXOS.LD_LIBRARY_PATHto prevent segmentation fault errors.This description was created by
for 189af75. It will automatically update as commits are pushed.