disable welcome page #141
Merged
disable welcome page #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Himanshu-Singh-Chauhan
requested review from
nang-dev,
Fryingpannn and
a team
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 815c05e in 10 seconds
More details
- Looked at
42lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/vs/workbench/contrib/welcomeGettingStarted/browser/startupPage.ts:36
- Draft comment:
Consider removing the commented-out lineconst oldConfigurationKey = 'workbench.welcome.enabled';if it is no longer needed. - Reason this comment was not posted:
Confidence changes required:50%
The commented-out line is not used anywhere else in the code, and it seems like the intent is to remove it. However, leaving it commented out can lead to confusion in the future.
Workflow ID: wflow_I5BKRIdH3Pkujn3d
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
nang-dev
pushed a commit
that referenced
this pull request
Jan 15, 2025
Himanshu-Singh-Chauhan
added a commit
that referenced
this pull request
Jan 16, 2025
Himanshu-Singh-Chauhan
added a commit
that referenced
this pull request
Jan 16, 2025
* disable welcome page (#141) * simple update banner
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
* disable welcome page (#141) * simple update banner
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
* disable welcome page (#141) * simple update banner
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
* disable welcome page (#141) * simple update banner
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
* disable welcome page (#141) * simple update banner
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
nang-dev
pushed a commit
that referenced
this pull request
Jan 27, 2025
* disable welcome page (#141) * simple update banner
Himanshu-Singh-Chauhan
pushed a commit
to Himanshu-Singh-Chauhan/pearai-app
that referenced
this pull request
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Disable welcome page if
workbench.startupEditoris set to 'none' instartupPage.ts.workbench.startupEditoris set to 'none' inStartupPageRunnerContribution.run().oldConfigurationKeyinstartupPage.ts, indicating deprecation.isStartupPageEnabled()to return false ifstartupEditor.valueis 'none'.This description was created by
for 815c05e. It will automatically update as commits are pushed.