Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix editor focus when close overlay #135

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

jpan8866
Copy link

@jpan8866 jpan8866 commented Dec 6, 2024


Important

Fixes editor focus issue by focusing the active editor after closing the overlay in pearOverlayPart.ts.

  • Behavior:
    • In pearOverlayPart.ts, after closing the overlay, the active editor is focused using this._editorGroupsService.activeGroup.focus().
  • Commands:
    • In pearOverlayService.ts, command strings are changed from single to double quotes for consistency.

This description was created by Ellipsis for 010d0a6. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 010d0a6 in 11 seconds

More details
  • Looked at 63 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/vs/workbench/browser/parts/overlay/pearOverlayService.ts:103
  • Draft comment:
    Consider using single quotes for consistency with the rest of the codebase unless there's a specific reason for using double quotes.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The PR changes single quotes to double quotes in the command registration strings. This is a minor style change and should be consistent across the codebase.

Workflow ID: wflow_uLzjAJf7SBNqITLF


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@jpan8866 jpan8866 merged commit 05650bd into main Dec 6, 2024
2 of 5 checks passed
Himanshu-Singh-Chauhan pushed a commit to Himanshu-Singh-Chauhan/pearai-app that referenced this pull request Jan 4, 2025
nang-dev pushed a commit that referenced this pull request Jan 27, 2025
nang-dev pushed a commit that referenced this pull request Jan 27, 2025
nang-dev pushed a commit that referenced this pull request Jan 27, 2025
nang-dev pushed a commit that referenced this pull request Jan 27, 2025
nang-dev pushed a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant