chore(ecmascript): used try and Assert Determination #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
previously approved these changes
Feb 12, 2025
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_prototype.rs
Show resolved
Hide resolved
nova_vm/src/ecmascript/builtins/indexed_collections/array_objects/array_prototype.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was the same with TypedArray, but using
assert_eq!(from_index.is_undefined(), n.into_i64() == 0);causes some test262 cases to fail.Even if I use
assert_eqonly when fromIndex is undefined, I believe it’s essentially doing the same thing.I also tried using
try_to_integer_or_infinity. However, based on my measurements using the time command on Unix, it didn’t seem to make things any faster.So, it might be pointless… but I gave it a shot anyway.