Add the Faker connector #23691
Open
Add the Faker connector #23691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin/trino-faker/src/main/java/io/trino/plugin/faker/ColumnInfo.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/ColumnInfo.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/ColumnInfo.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerColumnHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerColumnHandle.java
Outdated
Show resolved
Hide resolved
...rc/main/resources/docker/trino-product-tests/conf/environment/multinode-all/faker.properties
Show resolved
Hide resolved
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSourceProvider.java
Outdated
Show resolved
Hide resolved
Comment on lines
211
to
213
| for (int i = 0; i < positions; i++) { | ||
| generators.get(column).accept(output, completedRows + i); | ||
| } |
There was a problem hiding this comment.
You should loop over the columns and append N positions at a time to each column, that is more efficient than looping over columns for each position
There was a problem hiding this comment.
I'm a bit confused, isn't this already the case, since this is an inner loop? I just extracted generators.get(column) outside this loop.
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSourceProvider.java
Outdated
Show resolved
Hide resolved
|
@raunaqmorarka thanks a lot for the review, everything looks much nicer now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this connector would be similar to tpch/tpcds - generate random data to be used for all kinds of testing. The main difference is that this works with all Trino data types and any kind of schema. It's also using the Datafaker library, which allows generating more sophisticated random data in multiple languages.
For more details, including usage examples, see https://github.com/nineinchnick/trino-faker/
I'll add documentation if the general idea of adding this connector will be approved.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: