Simplify planning of MERGE #23684
Open
Simplify planning of MERGE #23684
+48
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsstarburst
approved these changes
Oct 4, 2024
core/trino-main/src/test/java/io/trino/sql/planner/TestDeleteAndInsertMergeProcessor.java
Outdated
Show resolved
Hide resolved
Currently, the planner inserts a projection of the following shape
to assemble the merged row:
merge_row := (
CASE
WHEN ... THEN
ROW(..., $not((present IS NULL)), <operation>, 0)
WHEN ... THEN
ROW(..., $not((present IS NULL)), <operation>, 1)
...
ELSE
ROW(<nulls>, $not((present IS NULL)), -1, -1)
END)
This change replaces the ELSE branch to return a single null instead of a synthetic
value with nulls. By reducing the size of the projection, it allows for wider
tables to be used with MERGE.
martint
force-pushed
the
merge-simplify
branch
from
965e345
to
ca494af
Compare
|
Hi, I tried this PR and it seems to help with one of the tables I was having trouble MERGING, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the planner inserts a projection of the following shape to assemble the merged row:
This change replaces the ELSE branch to return a single null instead of a synthetic value with nulls. By reducing the size of the projection, it allows for wider tables to be used with MERGE.
Related to #15848
Release notes
(x) Release notes are required, with the following suggested text: