Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "isort" with "reorder-python-imports" #501

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

arturdryomov
Copy link
Member

Description

See the motivation. Unfortunately the following reformatting is unavoidable (and cannot be reconfigured, see the explanation). It’s not a big deal from my POV but it’s a big change nevertheless.

from trino.client import ClientSession, TrinoQuery, TrinoRequest

⬇️

from trino.client import ClientSession
from trino.client import TrinoQuery
from trino.client import TrinoRequest

Release notes

This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Dec 12, 2024
@arturdryomov arturdryomov requested a review from hashhar December 12, 2024 20:27
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the style change is fine and I can agree about the reasoning (although in practice merge conflicts still happen if the imports being changed have any common lines in the "diff context").

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume other than this file everything else was automated change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, no manual changes besides the new hook.

@hashhar hashhar requested a review from damian3031 December 13, 2024 10:32
@hashhar hashhar merged commit 58f8164 into trinodb:master Dec 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants