TxDetail - XRP - Display destination tag #16634
Open
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasklim
reviewed
Jan 28, 2025
| @@ -5462,6 +5462,10 @@ export default defineMessages({ | |||
| defaultMessage: 'Destination tag', | |||
| id: 'DESTINATION_TAG', | |||
| }, | |||
| DESTINATION_TAG_SHORT: { | |||
| defaultMessage: 'DT', | |||
There was a problem hiding this comment.
Suggested change
| defaultMessage: 'DT', | |
| defaultMessage: 'Memo/Tag', |
This would maybe be better? Please @jirih-stsh
There was a problem hiding this comment.
It seems better to me, so I changed it.
izmy
force-pushed
the
feat/tx-detail-destination-tag
branch
from
a9c5039 to
367c8ed
Compare
izmy
force-pushed
the
feat/tx-detail-destination-tag
branch
2 times, most recently
from
136d7c9 to
c959e1a
Compare
izmy
force-pushed
the
feat/tx-detail-destination-tag
branch
3 times, most recently
from
7003a35 to
f1fcd5a
Compare
izmy
force-pushed
the
feat/tx-detail-destination-tag
branch
from
f1fcd5a to
72ac5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the destination tag into TxDetail.
Related Issue
Resolve #3375
Screenshots: