Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite): use TrezorLink in IOAddress to handle tor properly #16629

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

martykan
Copy link
Member

Description

Updated IOAddress to use TrezorLink instead of just Link when linking to explorer, so now the address is correctly converted to .onion when using Tor.

@martykan martykan force-pushed the fix/explorer-onion-link branch from faf87f8 to 42bd230 Compare January 27, 2025 16:33
@martykan martykan changed the base branch from feat/walletconnect to develop January 27, 2025 16:33
@martykan martykan force-pushed the fix/explorer-onion-link branch from 42bd230 to 4b7845c Compare January 27, 2025 16:34
Copy link

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

@martykan martykan marked this pull request as ready for review January 27, 2025 16:43
@mroz22 mroz22 requested a review from komret January 28, 2025 12:05
@martykan martykan merged commit 74a5713 into develop Jan 28, 2025
33 checks passed
@martykan martykan deleted the fix/explorer-onion-link branch January 28, 2025 12:21
@bosomt
Copy link
Contributor

bosomt commented Jan 29, 2025

QA OK

#8808
this issue is not yet solved and affets onion as well
so not all explorer links are opened as onion links

Info:

  • Suite version: desktop 25.2.0 (366cb09)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.2.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T3T1 2.8.7 regular (revision 8a254aa8eae82f99630df63f40e4d290066a3efc)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants