Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better UI for Destination tag in the send form #16621

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

izmy
Copy link
Contributor

@izmy izmy commented Jan 27, 2025

Description

Improve Destination tag input visibility in the send form based on updated UI design

Related Issue

Resolve #16513

Screenshots:

image

image

image

Before

image

image

@izmy izmy requested a review from tomasklim January 27, 2025 16:02
@izmy izmy self-assigned this Jan 27, 2025
@izmy izmy force-pushed the feat/ripple-destination-tag branch from bc11457 to 91e8611 Compare January 28, 2025 11:59
@izmy izmy requested a review from a team as a code owner January 28, 2025 11:59
@izmy izmy force-pushed the feat/ripple-destination-tag branch from 91e8611 to 68d4ebc Compare January 28, 2025 15:22
@tomasklim
Copy link
Member

/rebase

Copy link

@trezor-ci trezor-ci force-pushed the feat/ripple-destination-tag branch from 68d4ebc to 9edfec4 Compare January 28, 2025 15:55
@izmy izmy force-pushed the feat/ripple-destination-tag branch from 9edfec4 to e226524 Compare January 28, 2025 16:40
@jvaclavik
Copy link
Contributor

Screenshot 2025-01-29 at 9 59 47

@jvaclavik
Copy link
Contributor

Btw could you please add for next PRs screenshots "before" and "after"? 🙏 it's easier to understand what actually changed and how it looked like before. Thanks!

@izmy
Copy link
Contributor Author

izmy commented Jan 29, 2025

Btw could you please add for next PRs screenshots "before" and "after"? 🙏 it's easier to understand what actually changed and how it looked like before. Thanks!

Sure, I added "before".

@izmy izmy force-pushed the feat/ripple-destination-tag branch from e226524 to c2f35a0 Compare January 29, 2025 14:16
@izmy izmy force-pushed the feat/ripple-destination-tag branch from c2f35a0 to 1bc3579 Compare January 29, 2025 14:24
@izmy
Copy link
Contributor Author

izmy commented Jan 29, 2025

Screenshot 2025-01-29 at 9 59 47

Done... I added gap as props to <Note />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ripple memo / destination tag in send and receive form
3 participants