Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite): redesign FW checks UI #16599
feat(suite): redesign FW checks UI #16599
Changes from all commits
8363b05
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this caused problem and TS check didn't see it for some reason. In
SecurityCheck
there ischecklistItems
varaible, whereicon
isstring
. That's likely the reason. Cozstring
is aReactNode
.Before,
string
was kinda correct here as it was theIconName
.My proposal: enforce the
Icon
element here. I am not sure how to do it correctly. I can check if<Icon />
is its own Component type and require just it, or to removestring
from theReactNode
type here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am figuring out proper fix here: #16709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed all those checklist definitions 🤦
Yeah, exclude
string
fromReactNode
could work, but would need comment to explain why...EDIT:
ReactElement
is more suitable..