Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): rework pagination #16588

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

necky2
Copy link

@necky2 necky2 commented Jan 24, 2025

Hi, I am applying for a job at Trezor and I wanted to get more familiar with the repo. Thought it could be fun to try to solve some simple issue and explore the code while doing it. ✌️ LMK if you find any issues.

Description

  • Added a limit of 7 pages. (same as MUI)
  • Changed the chevrons to be always visible. They now get disabled instead of hidden on the first/last page. This prevents the component from jumping around. (same as MUI)

Q: Do the single chevrons and double chevrons need to stay? They are a bit redundant now with this type of pagination. MUI shows single chevrons and hides double chevrons by default.

Possible issues to be solved separaterly:

  • The page buttons are in reality DIVs and can't be controlled with a keyboard. This is bad for accessibility, but I am not yet familiar with the conventions of this project.
  • Pagination for XRP is visually broken, with overlapping text of "Newer" and "Older". It was like this before my changes and I don't know what it's supposed to look like.
image

Related Issue

Resolve #16565

Screenshots:

image

@necky2 necky2 force-pushed the feat/pagination-rework branch from f049721 to 97345f9 Compare January 24, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solana pagination great again
1 participant