Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the rotating version of the image to the security check onboarding screen #16571

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

vojtatranta
Copy link
Contributor

@vojtatranta vojtatranta commented Jan 23, 2025

A draft PR that validates the way of how we want to properly replace those images.

ADD

  • ✅ make sure that the color is taken from the device in the "live" version
  • ✅ PRINT OUT THE pretty print of color to the name of the device
  • ✅ denser version of the animations for all cases
  • ✅ update animation fo T1B1 small and large
  • ✅ update the images of the T1B1 trezor-t1b1-large.png and others

Description

A task was to add the rotation variants of the "image" to the onboarding "security check" screen. And then also update the image of the T1B1 trezor that has a pronounced buttons. So as bullet points

  • rendered "name" of the color of the device next to the Device name at the security check
  • added 600p rotation versions of the "device image" to the security check to all devices
  • update image of the T1B1 with pronounced buttons

Related Issue

Resolve #16509

Screenshots:

  • well, that's a lot of screenshots to share, asked @jvaclavik to figure out the way how to test it properly (we have tested with my previous debug util - color and model in the url)

What to check

  • that all the device images have rotating version on the security check correct along their color (default is black)
  • that the T1B1 has a new image and rotation in Device status and where the base variants of the device image is used (image trezor-t1b1[variant?].png)
  • that the color name is displayed next to the device name at the security check

@vojtatranta vojtatranta force-pushed the feat/animated-onboarding-illustrations branch from cd3c7b4 to 280c14a Compare January 23, 2025 14:35
@vojtatranta vojtatranta force-pushed the feat/animated-onboarding-illustrations branch from 280c14a to fc5ccec Compare January 24, 2025 12:45
@vojtatranta vojtatranta force-pushed the feat/animated-onboarding-illustrations branch 4 times, most recently from 7c77eb2 to 6d70ef0 Compare January 29, 2025 09:53
@vojtatranta vojtatranta changed the title WIP: Add the rotating version of the image to the security check onboarding screen Add the rotating version of the image to the security check onboarding screen Jan 29, 2025
@vojtatranta vojtatranta requested a review from jvaclavik January 29, 2025 10:25
@vojtatranta vojtatranta marked this pull request as ready for review January 29, 2025 10:28
@vojtatranta vojtatranta requested review from komret and a team as code owners January 29, 2025 10:28
@vojtatranta vojtatranta self-assigned this Jan 29, 2025
@vojtatranta
Copy link
Contributor Author

Needs QA

@vojtatranta vojtatranta force-pushed the feat/animated-onboarding-illustrations branch from 6d70ef0 to 58fb7fe Compare January 29, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤝 Needs QA
Development

Successfully merging this pull request may close these issues.

Device rotation in Security check - PoC
1 participant