-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the rotating version of the image to the security check onboarding screen #16571
Open
vojtatranta
wants to merge
5
commits into
develop
Choose a base branch
from
feat/animated-onboarding-illustrations
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtatranta
force-pushed
the
feat/animated-onboarding-illustrations
branch
from
January 23, 2025 14:35
cd3c7b4
to
280c14a
Compare
vojtatranta
commented
Jan 23, 2025
packages/suite/src/components/suite/SecurityCheck/SecurityCheckLayout.tsx
Outdated
Show resolved
Hide resolved
vojtatranta
commented
Jan 23, 2025
packages/suite/src/components/suite/SecurityCheck/SecurityCheckLayout.tsx
Outdated
Show resolved
Hide resolved
vojtatranta
commented
Jan 23, 2025
vojtatranta
commented
Jan 23, 2025
packages/suite/src/components/suite/SecurityCheck/SecurityCheckLayout.tsx
Outdated
Show resolved
Hide resolved
vojtatranta
force-pushed
the
feat/animated-onboarding-illustrations
branch
from
January 24, 2025 12:45
280c14a
to
fc5ccec
Compare
vojtatranta
commented
Jan 24, 2025
packages/suite/src/components/suite/SecurityCheck/SecurityCheckLayout.tsx
Outdated
Show resolved
Hide resolved
vojtatranta
force-pushed
the
feat/animated-onboarding-illustrations
branch
4 times, most recently
from
January 29, 2025 09:53
7c77eb2
to
6d70ef0
Compare
vojtatranta
changed the title
WIP: Add the rotating version of the image to the security check onboarding screen
Add the rotating version of the image to the security check onboarding screen
Jan 29, 2025
Needs QA |
vojtatranta
force-pushed
the
feat/animated-onboarding-illustrations
branch
from
January 29, 2025 16:27
6d70ef0
to
58fb7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft PR that validates the way of how we want to properly replace those images.
ADD
trezor-t1b1-large.png
and othersDescription
A task was to add the rotation variants of the "image" to the onboarding "security check" screen. And then also update the image of the T1B1 trezor that has a pronounced buttons. So as bullet points
Related Issue
Resolve #16509
Screenshots:
What to check
trezor-t1b1[variant?].png
)