-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite): add support for Solana staking rewards #16527
base: develop
Are you sure you want to change the base?
Conversation
...ges/suite/src/views/wallet/staking/components/SolStakingDashboard/components/RewardsList.tsx
Outdated
Show resolved
Hide resolved
d57a76b
to
f700b29
Compare
@@ -12,3 +12,6 @@ export const EVERSTAKE_ENDPOINT_PREFIX: Record< | |||
sol: 'https://dashboard-api.everstake.one', | |||
dsol: 'https://dashboard-api.everstake.one', | |||
}; | |||
|
|||
export const EVERSTAKE_REWARDS_SOLANA_ENPOINT = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add to allowedDomains config.ts
in suite-desktop-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, forgot about it. Added 9c30965
const isSolanaMainnet = account.symbol === 'sol'; | ||
|
||
const fetchRewards = useCallback( | ||
async ({ symbol, descriptor }: Account) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought: what do you think about moving whole logic with fetching and paging into a hook (useSolanaRewards ?) to make this component simpler? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, it looks better now 9c30965
f700b29
to
00e51b6
Compare
9c30965
to
9fca587
Compare
Description
This PR adds rewards to the Solana staking dashboard. Key changes:
Related Issue
Resolve #16597
Screenshots: