feat: Cancel Transaction #16525
Draft
feat: Cancel Transaction #16525
+967
β449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
commented
Jan 22, 2025
| // override Account data, similar to RBF | ||
| const cancelAccount: ConnectCallParams['account'] = { | ||
| ...account, | ||
| utxo: getMineInputsFromTransaction({ tx, account }), |
There was a problem hiding this comment.
Theoretically we may only double-spend any of the inputs of the original transaction. That may reduce the trace on-chain.
However, the Electrum wallet also spends all mine inputs so maybe we shall keep it same.
|
π Expo preview is ready!
|
peter-sanderson
commented
Jan 22, 2025
| outputs: [ | ||
| { | ||
| type: 'send-max', | ||
| address: account.addresses?.unused[0].address, // Todo: is this correct way? |
There was a problem hiding this comment.
Electrum tries to use original change output if present in the original transaction:
out_address = (self.get_single_change_address_for_new_transaction(old_change_addrs)
or self.get_receiving_address())
peter-sanderson
commented
Jan 22, 2025
...s/ReduxModal/UserContextModal/TxDetailModal/AffectedTransactions/AffectedTransactionItem.tsx
Outdated
Show resolved
Hide resolved
peter-sanderson
force-pushed
the
cancel-transaction
branch
from
0b0d520 to
7e127f9
Compare
This was referenced Jan 23, 2025
Merged
peter-sanderson
force-pushed
the
cancel-transaction
branch
3 times, most recently
from
ac59862 to
9b26270
Compare
2 tasks
peter-sanderson
commented
Jan 23, 2025
| TR_CANCEL_TX_NOTICE: { | ||
| id: 'TR_CANCEL_TX_NOTICE', | ||
| defaultMessage: | ||
| 'Once the transaction is canceled successfully, your funds (minus the transaction fee) will be returned to your wallet.', |
There was a problem hiding this comment.
Once the transaction is canceled successfully, your funds (minus the transaction fee) will be returned to your wallet.
There was a problem hiding this comment.
(design update)
# Conflicts: # packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/AffectedTransactions/AffectedTransactionItem.tsx # packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/AffectedTransactions/AffectedTransactions.tsx # packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ChangeFee/ChangeFee.tsx # packages/suite/src/components/suite/modals/ReduxModal/UserContextModal/TxDetailModal/ChangeFee/DecreasedOutputs.tsx # packages/urls/src/urls.ts
peter-sanderson
force-pushed
the
cancel-transaction
branch
from
9b26270 to
dcf6053
Compare
peter-sanderson
force-pushed
the
cancel-transaction
branch
from
dcf6053 to
aa535b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π§ π§ π§ Still WIP π§ π§ π§
β Depends on #16569 π Merge this first!
Description
This PR Implements a Cancel Transaction flow by sending a RBF transaction what spends the (users) inputs back to thne users own address
Related Issue
Resolve #6810
Screenshots: