Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quality and dimensions of device images used in the app #15053

Open
yanascz opened this issue Oct 24, 2024 · 1 comment
Open

Fix quality and dimensions of device images used in the app #15053

yanascz opened this issue Oct 24, 2024 · 1 comment
Labels
mobile Suite Lite issues and PRs

Comments

@yanascz
Copy link
Contributor

yanascz commented Oct 24, 2024

We've already tweaked the existing images in https://github.com/trezor/trezor-suite/pull/14946/files#diff-813dd60bf71a0234e5f2845f8a930bad91e3df4f086e75165aeabc659b3b810f. However, it was just a quick & dirty solution.

Requirements by @shenkys as follows:

  • Same height for the default render (meaning it can always be replaced with another render without needing to adjust the size for visual balance).
  • Safe space only at the top edge (to allow for an animation of cable connection without being offset by the internal safe space).
  • Height of 1200px; width is flexible. Each device can either have the same width or it can be standardized in some way, including safe spaces. However, scaling it in the app is not a problem.
@yanascz yanascz added the mobile Suite Lite issues and PRs label Oct 24, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Oct 24, 2024
@matejkriz
Copy link
Member

@fang314 This is both user-facing (image for Modal T is not ideal now) and to make it easier for use to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
Status: 🎯 To do
Development

No branches or pull requests

2 participants