Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): separate base and priority Solana fees #4641

Closed
wants to merge 1 commit into from
Closed

refactor(core): separate base and priority Solana fees #4641

wants to merge 1 commit into from

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Feb 17, 2025

Move fee calculation into Transaction class.

Also, replace floating-point division by integer division in fee calculation.

It will be used in #4639.

@romanz
refactor(core): separate base and priority Solana fees
1a00ae5 
Move fee calculation into `Transaction` class.

Also, replace floating-point division by integer division in fee calculation.

[no changelog]
@romanz romanz self-assigned this Feb 17, 2025
@romanz romanz added core Trezor Core firmware. Runs on Trezor Model T and T2B1. altcoin Any non-Bitcoin coins labels Feb 17, 2025
@romanz romanz requested a review from matejcik February 17, 2025 20:32
@github-actions GitHub Actions
Copy link

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz marked this pull request as ready for review February 17, 2025 21:50
@romanz romanz mentioned this pull request Feb 18, 2025
Open
@romanz
Copy link
Contributor Author

romanz commented Feb 18, 2025

I have used https://solana.com/docs/core/fees for base & priority fee definitions.

@romanz romanz closed this Feb 21, 2025
@romanz romanz removed the request for review from matejcik February 21, 2025 12:27
@romanz
Copy link
Contributor Author

romanz commented Feb 21, 2025

Will be done in #4639.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@romanz romanz

Labels
altcoin Any non-Bitcoin coins core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
Firmware
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romanz