Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use deterministic git rev-parse #13

Closed
wants to merge 1 commit into from

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Dec 3, 2024

No description provided.

@matejcik
Copy link

matejcik commented Dec 3, 2024

this won't help in the general case: --short=7 will show at minimum 7 chars but there's no upper limit.
we'll need something like git rev-parse HEAD then result[:7]

@matejcik
Copy link

matejcik commented Dec 3, 2024

perhaps it is better to define MICROPY_BANNER_NAME_AND_VERSION symbol to trezor or sth

@mmilata
Copy link
Member Author

mmilata commented Dec 3, 2024

I see, it uses the output of git describe --tags which can also change on shallow repo with no tags. Overriding MICROPY_BANNER_NAME_AND_VERSION is better and needs no changes in this repo.

@mmilata mmilata closed this Dec 3, 2024
@mmilata mmilata deleted the mmilata/git-rev-parse branch December 3, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants