Fix for logical column types #26
Conversation
| #' @param cls character | ||
| #' @return converted vector | ||
| #' @seealso https://stackoverflow.com/questions/9214819/supply-a-vector-to-classes-of-dataframe | ||
| toCls = function(x, cls) tryCatch(do.call(paste("as", cls, sep = "."), list(x)), |
There was a problem hiding this comment.
If you don't mind, can you make these non-Roxygen docs? Otherwise a spurious entry in the package docs gets created for an internal function that we don't want to export. If you just remove the ' from #' that should do the trick (on this and setHtableClass).
There was a problem hiding this comment.
Sure, this is the consequence of copy&paste approach :) I'll fix it
|
Thanks for resurrecting this feature and taking the time to put the PR together. Just a couple of little concerns commented above but otherwise I think this will be good to go. |
|
Oh, and to give credit where credit is due, can you add in attribution for any code that you took from @jrowen (maybe an |
|
All fixes should be included now. |
Fix for logical column types
|
Thanks! |
There is an error with updating logical values discussed in #18 and this error has been fixed by @jrowen in pull request #15
And because it seems @jrowen won't continue on this pull request, I have decided to grab at least changes related to this issue and make a standalone pull request.