Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient Choice of Download #260

Open
hdevine825 opened this issue Oct 15, 2024 · 2 comments
Open

Efficient Choice of Download #260

hdevine825 opened this issue Oct 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@hdevine825
Copy link

Is your feature request related to a problem? Please describe.

When generating maps for a specific tile or range of tiles, the download size should be somewhat optimized. For example, when running python -m wahoomc cli -xy 75/96 it will identify the following involved countries:

INFO:# Determine involved/border countries
INFO:+ Involved country: us
INFO:+ Involved country: us_connecticut
INFO:+ Involved country: us_new-jersey
INFO:+ Involved country: us_new-york

This will result in a much larger download than ideal.

Describe the solution you'd like

Either only download the subregions: us_connecticut, us_new-jersey, us_new-york or allow a specified country when selecting an -xy location. For example python -m wahoomc cli -xy 75/96 -co us_connecticut,us_new-jersey,us_new-york

@hdevine825 hdevine825 added the enhancement New feature or request label Oct 15, 2024
@treee111
Copy link
Owner

Hi @hdevine825,
thanks for your ehancement-request!

I thought about this as well during implementation of the -xy and -nbc arguments.
I came up with the conclusions that when running -xy mode:

  1. most of the time only one country is relevant (unless your hometown is at the border to another country)
  2. it is straight-forward to generate the whole tile instead of only parts of it
  3. one would have a non-equal result of the map creation when not using raw country-map files of all countries because on the rest of the tile, land/water as well as elevation, POIs etc. would be rendered independent of the raw map-files

From your post I understand that the three subregions are correct and us not needed in your opinion.

To clarify your request more:

  1. Are some of the the downloaded files identical? I.e. filesize?
  2. Are the involved countries - in general - correct for the tile you are using wahooMapsCreator for?

Thanks!

@hdevine825
Copy link
Author

hdevine825 commented Oct 16, 2024

To clarify the issue I am concerned with is only around download size. I saw what it was attempting to download and didn't finish running. I can test later on a machine with more HDD space available and see what ultimately is downloaded.

  1. most of the time only one country is relevant (unless your hometown is at the border to another country)

It appears that it will try to download the full country and a subregion (the us_... countries in this case) that duplicates some of the country level data.

  1. Are some of the the downloaded files identical? I.e. filesize?

As noted above some will be duplicated.

The two normal options (and one special case) for downloading that would give the data needed:

  1. Downloading the full United States is 9.9 GB or
  2. Downloading New York at 433 MB plus New Jersey at 140 MB plus Connecticut at 195 MB for a total of 768 MB or
  3. There is a "special sub-region" of US Northeast (1.5 GB) that also covers the needed tile, but I don't think that is a very common case.
  1. Are the involved countries - in general - correct for the tile you are using wahooMapsCreator for?

Yes. They are all relevant to the tile requested. However, the subregions duplicate the full United States data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants